Skip to content

Fix base_url in local mode procedures#28

Closed
vondravl wants to merge 1 commit intomainfrom
feature/v1.7.1
Closed

Fix base_url in local mode procedures#28
vondravl wants to merge 1 commit intomainfrom
feature/v1.7.1

Conversation

@vondravl
Copy link
Copy Markdown
Owner

Summary

  • Fix "None" in procedure URLs: run_post_export_sql() now accepts a config parameter from the caller instead of always creating a fresh ExportConfig(load_from_env=True), preventing "None" appearing in curl command URLs when running in local mode without .env files
  • DB metadata fallback: Falls back to dictionary_metadata table in the database if BASE_URL is still None
  • Safe parameter substitution: substitute_parameters() now skips substitution when a config value is None instead of converting to literal "None" string

Test plan

  • Run gooddata-export enrich --db-path <path> in local mode without .env files — verify procedures don't contain None in URLs
  • Run gooddata-export export in API mode — verify post-export procedures still work correctly
  • Run pytest — all 194 tests pass

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vondravl
Copy link
Copy Markdown
Owner Author

Superseded by v1.8.0 release PR

@vondravl vondravl closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant